Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/run: do not create needless dev/data/ dir #1786

Merged
merged 2 commits into from
Dec 1, 2018
Merged

dev/run: do not create needless dev/data/ dir #1786

merged 2 commits into from
Dec 1, 2018

Conversation

wohali
Copy link
Member

@wohali wohali commented Nov 30, 2018

Overview

dev/run has been creating a dev/data directory needlessly. Long ago we moved the data directory under dev/lib/node#/data to support multiple clusters. Confuses me every time.

Testing recommendations

dev/run, kill it, make sure dev/data is not created.

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes n/a

@wohali wohali requested a review from eiri November 30, 2018 21:09
@wohali wohali merged commit 9f7724e into master Dec 1, 2018
@wohali wohali deleted the no-dev-data-dir branch December 1, 2018 05:31
@wohali wohali mentioned this pull request Feb 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiri eiri eiri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wohali @eiri