Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement
delete_on_exit/1
and use it to delete replication dbs for tests which currently lack clean up. Replace existing on_exit calls with new function.Testing recommendations
Before this PR, run
mix test --trace test/replication_test.exs
and then look at/all_dbs
and notice all the dbs likerandom-test-db--576460750833332000--576460752303423488_src
etc.After deleting those test dbs, apply this PR and run the tests again: all replication dbs should have been cleaned up.
Related Issues or Pull Requests
Checklist