Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up replication dbs on exit #1463

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

jaydoane
Copy link
Contributor

Overview

Implement delete_on_exit/1 and use it to delete replication dbs for tests which currently lack clean up. Replace existing on_exit calls with new function.

Testing recommendations

Before this PR, run mix test --trace test/replication_test.exs and then look at /all_dbs and notice all the dbs like random-test-db--576460750833332000--576460752303423488_src etc.

After deleting those test dbs, apply this PR and run the tests again: all replication dbs should have been cleaned up.

Related Issues or Pull Requests

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

Implement delete_on_exit/1 and use it to delete replication dbs for
tests which currently lack clean up. Replace existing on_exit calls with
new function.
@janl janl merged commit b8b6a3d into apache:elixir-suite Jul 24, 2018
@jaydoane jaydoane deleted the clean-up-replication-dbs branch August 14, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants