Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISCUSS] Validate new document writes against max_http_request_size #1253

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[DISCUSS] Validate new document writes against max_http_request_size #1253

wants to merge 9 commits into from

Commits on Mar 29, 2018

  1. feat: validate new document writes against max_http_request_size 

    The validation path is now the following:

If a new doc body is > max_document_size, we throw an error.

If a new attachment is > max_attachment_size, we throw an error.

If the new doc body in combination with new and/or existing
attachments is > max_http_request_size, we throw an error.

This also sets the max_document_size to 2 GB, to restore 1.x and
2.0.x compatibility.

Closes apache#1200
    @janl
    janl committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    6755eac View commit details
    Browse the repository at this point in the history

  2. wip

    @janl
    janl committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    ee70b56 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. fix comment

    @janl
    janl committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    0e06697 View commit details
    Browse the repository at this point in the history

  2. hardcode mock uuid

    @janl
    janl committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    616ec02 View commit details
    Browse the repository at this point in the history

  3. remove debug log

    @janl
    janl committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    797c6d7 View commit details
    Browse the repository at this point in the history

  4. smarter uuid

    @janl
    janl committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    e6ae447 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat/max-req-size

    @janl
    janl committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    dac755b View commit details
    Browse the repository at this point in the history

  6. Better total (body + attachments) size checking for documents 

    Use the already computed (conservative) body size.

Switch multipart length calcuation to accept body and boundary sizes.

Issue apache#1200
Issue apache#1253
    @nickva
    nickva committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    244442c View commit details
    Browse the repository at this point in the history

  7. Merge pull request #6 from cloudant/better-total-doc-size-checking 

    Better total (body + attachments) size checking for documents
    @janl
    janl committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    e2f556d View commit details
    Browse the repository at this point in the history