Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for http API status code responses in different quorum conditions #1157

Merged
merged 3 commits into from
Jul 9, 2018

Conversation

jjrodrig
Copy link
Contributor

@jjrodrig jjrodrig commented Feb 9, 2018

Overview

Add testing for http API status code responses in different quorum conditions

Testing recommendations

make test-cluster-with-quorum
make test-cluster-without-quorum

Related Issues or Pull Requests

Covers the testing described in #1156

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@janl janl added this to the 2.2.0 milestone Feb 28, 2018
@wohali
Copy link
Member

wohali commented Mar 26, 2018

@janl do we really want to add a bunch of new couchjs-based tests at this point? I am -0.5.

@janl
Copy link
Member

janl commented Jul 9, 2018

@wohali this is stuff we are not testing at the moment and the Elixir tests are still being filled out, so why not? :)

@wohali
Copy link
Member

wohali commented Jul 9, 2018

as I said I won't block, I'm glad for more tests, I'd just prefer them to be in Elixir :)

@janl janl merged commit 7dfed0c into apache:master Jul 9, 2018
@janl
Copy link
Member

janl commented Jul 9, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants