Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uuid in tmp db names in unit tests #1092

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

eiri
Copy link
Member

@eiri eiri commented Jan 4, 2018

Overview

This changes naming of temporary eunit databases and files from using unique_monotonic_integer to couch_uuids:random to remove performance penalty and normalize naming across erlang releases.

Also getting rid of unnecessary inter-types convertion.

Testing recommendations

make eunit should come clean. Files in $PWD/tmp should be named like tmp/data/eunit-test-db-a6a4cd31f2addf2791440b3e8b54f860.1515084353.couch or tmp/tmp_data/nonode@nohost-018448e4ebb1f85812fd96d56939a620

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

This changes naming of temporary eunit databases
and files from using unique_monotonic_integer to
couch_uuids:random to remove performance penalty
and normalize naming across erlang releases.

Also getting rid of unnecessary inter-types
convertion.
@eiri eiri requested a review from nickva January 4, 2018 17:06
@eiri eiri merged commit bc192d1 into master Jan 4, 2018
@eiri eiri deleted the use-uuid-in-eunit-dbnames branch January 4, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants