-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move _users _design/auth into Erlang #666
Comments
Same thing would be good for the _replicator db's |
+1 with the caveat that we should't do this via enabling the erlang view server since that's leads to other issues (unless until Erlang figures out sandboxing). |
The first steps would be to transliterate these two files into native Erlang. After that, we could figure out how we can hard-wire them into their respective databases without enabling the Erlang view server: https://github.com/apache/couchdb/blob/master/src/couch/include/couch_js_functions.hrl This would make a great first time contribution, any one of the functions would already be a good help. See https://github.com/apache/couchdb/blob/master/test/javascript/tests/erlang_views.js for a few examples of how to write ddoc functions in Erlang. Please no comments about us embedding JS in Erlang in one case, and Erlang in JS in the other ;D |
Hi to all! I have made translation functions to erlang for _users view. @janl check, please, this Did you mean some like this? |
@abc3 can you open a pull request for this please? Your patch got lost :) |
Yes, sure. |
I understand the same will have to be done for |
@evsukov89 yes, that would be great to get _design/_replicator into Erlang and not it as a "system" _design doc. |
@nickva but wouldn't this not be enough? porting the validation functions to Erlang is only half the job, the rest is to integrate them directly into couch code that already handles |
Right now we enforce
_users
to have a_design/auth
ddoc with a VDU in it that we force the value of.Expected Behavior
_users VDU should be hard-coded in Erlang and enforce the same rules as the JS VDU today.
Current Behavior
We forcibly create
_users/_design/auth
and forcibly maintain the contents of its VDU.Context
This would be a prerequisite towards an optional no-couchjs version of CouchDB 2.x, something we discussed in janl/couchdb-next#23 .
The text was updated successfully, but these errors were encountered: