-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fauxton-visual-guide #4
Conversation
You should use official CouchDB logo for speaking couch. Imagine that those person speaks. |
TOC link is too pale and it's easy to miss it. |
|
While in overview you provides a link to CouchDB 1.6.1 documentation, all API reference goes to latest version which is for 2.0. |
Grey text on grey background hard to read. May be make it a bit bolder and blacker? |
There are no delimiters between Active Tasks and Config and the rest of text. May be rephrase text to better integrate internal links into it or add some explicit delimiter like UPD: Well, here is indeed you can embed internal link with easy:
|
On replication section figures 1 and 2 on image are not explained. |
It's quite strange to say "Hi" at the end of the page. |
In everything else - awesome work! |
@kxepal I pushed changes per your feedback onto my github.io page, and to this branch. I think I got all the links you were talking about (I hope) and they now point to latest version instead of 1.6.1. Let me know if you like these new colors better :) I darkened the TOC, but its still a little light in color, because I don't want it to be too obtrusive while reading the rest of the page. The header bar diagram: :/ I don't like this graph too much either. I went through a handful of versions for this diagram, and maybe I have been looking at it too long. I will have to think about it some more. If you have any suggestions let me know please. I didn't want to say 'good-bye' at the end. So I just said Hi! instead! Hi! |
@@ -0,0 +1 @@ | |||
*{margin:0;padding:0;-webkit-text-size-adjust:none}body,a{color:#291d1e}body,h1,h2,h3,h4,pre{font-size:16px;font-family:'HelveticaNeue-Light',Helvetica,Arial,sans-serif;font-weight:300}h1{font-size:34px}h2{font-size:34px;padding:48px 0}b,strong{font-family:'HelveticaNeue-Bold',Helvetica,Arial,sans-serif;font-weight:900}#toggle-toc-button{color:#888;right:20px;top:20px;font-size:12px;padding:10px;position:fixed;font-family:Arial,sans-serif;z-index:1001}#toggle-toc-button:hover{cursor:sw-resize}#toggle-toc-button.x{height:35px;width:100px;font-size:8px;text-align:right;margin-right:6px}#toggle-toc-button.x:hover{cursor:ne-resize}#toc{z-index:1000;width:200px;margin:20px;padding:20px;list-style-type:none;position:fixed;right:5px;background-color:rgba(255,255,255,0.9)}#toc li{padding:2px}#toc a{color:#c56969;text-decoration:none}#toc a:hover{text-decoration:underline}#toc.hidden{display:none}.pagecontainer{min-height:800px;clear:both}.page{min-height:800px;overflow-y:scroll}.page img{margin-top:70px;height:600px;display:block;margin-left:auto;margin-right:auto}.page img.couch{height:auto;position:relative;top:50%;-webkit-transform:translateY(50%);-ms-transform:translateY(50%);transform:translateY(50%)}.leftside{width:50%;float:left}.rightside{color:green;width:50%;float:right;height:100%}.linen{background:url(assets/linen.jpg) #eee 50% 0%}.textbox{color:gray;border:1px solid #d8d8d8;min-height:600px;width:87%;margin:auto;margin-top:70px;margin-bottom:50px;background-color:rgba(242,242,242,0.85);overflow:hidden}.textbox h1{font-size:30px;text-align:center;margin:20px 10px;color:#B5B5B5}.textbox p{padding:5px 30px 15px 30px;line-height:1.5}.textbox p.br{padding:0 30px;line-height:1}.textbox p.indent{margin-left:15px}.textbox p.question{font-weight:600;padding-bottom:0}.textbox p.answer{padding-top:0}#introBox{text-align:center;min-height:320px;display:block;position:relative;top:50%;-webkit-transform:translateY(50%);-ms-transform:translateY(50%);transform:translateY(50%)}#introBox h1{margin-top:100px}#introBox h1{font-size:60px;color:#C0C0C0}#introBox h2{font-size:16px;padding:0}#page-overview img{margin-top:300px;height:auto}#page-header-bar img{padding:30px;height:800px}#page-answers img{height:auto} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like compiled output, where is the source for it?
@michellephung can we change our makefile to something like (caution, untested) all: style/master.css fauxton-visual-guide
style/master.css: style/master.less
lessc $< > $@
fauxton-visual-guide:
harp compile src-fauxton-visual-guide fauxton-visual-guide
clean:
rm style/master.css
rm -rf fauxton-visual-guide and check in the sources of the folder |
i can will work more on the diagram and the make file, for getting it in a better place to compile/work with for this pr on friday or monday. could you guys look over the cors section. I think I wrote it wrong. I'm sorry. 😟 |
section. </p> | ||
</div></div></div><div id="page-cors" class="pagecontainer"><div class="leftside page"><img src="assets/cors.png"></div><div class="rightside linen page"><div class="textbox"><h1 id="cors">CORS</h1> | ||
<p>CORS stands for Cross Origin Resource Sharing. It is setting that | ||
pertains only to browsers.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it "It is a setting.." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
Slick! Very nice job, @michellephung.
|
7aa800d
to
294a8ae
Compare
This is awesome! Great work @michellephung! My only suggestion is in the |
I am still working on this! I needs more time. |
Super nice - good job :) |
b22dad7
to
1963df4
Compare
1963df4
to
d0c8d7c
Compare
Trying to add this:
http:https://michellephung.github.io/Fauxton-Visual-Guide/
to the site. Not sure if this is how I should do it, since make didn't make for me.