Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change column style when resize using bootstrap #39

Closed
wants to merge 1 commit into from

Conversation

pas-trop-de-zele
Copy link

Hello there, I came across the website and here's are my proposed new layout look with the help of bootstrap

Current: 2 column splitted into 2 section 3 and 3
image

New: Combined both sections to get a more streamlined look
2 columns


Current: 1 column left align
image
New: Centered
1 columns center

@wohali
Copy link
Member

wohali commented Sep 21, 2021

HI there, thanks for the PR! Welcome to the CouchDB community.

Does your solution work when all JS is disabled in the browser? The current website degrades gracefully with no JS support.

I am also unconvinced that adding an entire framework (like Bootstrap) is the best way to accomplish something as simple as centre-ing.

You should be able to achieve this with a pure CSS solution. If you can refactor to accomplish this without Bootstrap. we'll certainly consider the PR.

@pas-trop-de-zele
Copy link
Author

Hi Joan, thank you for getting back!

I believe it should work with JS disabled since I didn't included the JS script from bootstrap

Having said that, I agree that bootstrap may have been overkill for it, I was mocking it up for that was the fastest way to go for me 😁

I will refactor it with pure CSS and do another PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants