Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure TypeScript definitions are sound during testing #201

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

glynnbird
Copy link
Contributor

I noticed the TypeScript definitions weren't syntactically correct, so I fixed them and ensured that the npm run test command checks the TypeScript syntax too.

Overview

Fix TypeScript definition and ensure that the tests can't pass with invalid TypeScript definitions in the future.

Testing recommendations

npm run test

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@glynnbird glynnbird added the bug label Feb 14, 2020
@glynnbird glynnbird self-assigned this Feb 14, 2020
@glynnbird glynnbird merged commit 037a473 into master Feb 17, 2020
@glynnbird glynnbird deleted the fixuptypescript branch February 17, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants