ingress.className added

[sebastien-helbert]

What this PR does / why we need it:

add ingress.ingressClassName which replaces kubernetes.io/ingress.class annotation deprecated in Kubernetes 1.18

Which issue this PR fixes

• fixes Support IngressClass #69

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.

• Chart Version bumped
• e2e tests pass
• Variables are documented in the README.md
• Chart tgz added to /docs and index updated

[discostur]

Any chance to get this merged soon?

[broomfn]

+1 I really need this to, we've had to upgrade our ingress controllers and this is now causing us issues :-(

Does anyone know a work around or anyway to force the ingressClassName external to be set external to this helm chart?

Options I can think of:

1. Clone the helm chart and make the changes locally
2. run kubectl edit on the ingress after installing the helm chart

Thoughts?

[broomfn]

In the end I decided upon this command after installing the helm chart:

kubectl patch ingress/couch-couchdb --type json --patch '[{"op": "add", "path": "/spec/ingressClassName", value: "nginx" }]'

[krische]

Will this be merging soon?

[willholley]

@sebastien-helbert can you rebase this on main and delete the chart tarball from the PR? The chart test / release process is now supported by GitHub actions so the manual step of running e2e tests and creating the chart release is no longer required.

[sebastien-helbert]

@willholley done!

[willholley]

Just one comment around the documented default value. If you can rebase and bump the chart version, it's good to go.

[willholley]

It would also be good to add a note to couchdb/NEWS.md documenting the chart version and feature addition.

[sebastien-helbert]

It would also be good to add a note to couchdb/NEWS.md documenting the chart version and feature addition.

done

[PetrusZ]

We really need this. What's the problem now? Is it ready to merge? @willholley