Give the Service default port (5984) a name so that it is not ambiguous if service.extraPorts is used.
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us if service.extraPorts are used.
willholley
approved these changes
Jun 4, 2024
|
Thank you so much for reviewing these PRs so quickly, we really appreciate it 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sorry about this @willholley, but I noticed when trying to update to 4.5.4 and use my new
extraPortsvalues that if you try to have multiple ports on aServicein Kubernetes, all ports need aname(kubernetes/kubernetes#36803). If there's just one port, thisnameproperty is optional. Sadly this rendersservice.extraPortsuseless in 4.5.4, so for 4.5.5 I've given the default port a name.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
Variables are documented in the README.md(no new variables)