Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme for build spidermonkey60 #11

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

jiangphcn
Copy link
Contributor

@jiangphcn jiangphcn commented Dec 1, 2019

Overview

Add readme for building spidermonkey60 in Windows

Related Issues or Pull Requests

apache/couchdb#2170

@wohali
Copy link
Member

wohali commented Dec 4, 2019

@jiangphcn I ran out of time today but this is on my agenda for tomorrow.

@wohali
Copy link
Member

wohali commented Dec 5, 2019

@jiangphcn Hi Peng, thanks so much for this work. Clearly this took you a lot of time, and my own experiences are similar with how painstaking it can be.

There's still a bunch to do to make this useful for end users, as the instructions aren't yet step-by-step for everything. For me to use this to automate Windows builds I need full repeatable steps, in the same order along with everything else we build.

I'm going to suggest we leave this on the build-spidermonkey60 branch for now, until we can fully update README.md for SpiderMonkey 60. That means we'd close this PR but you should keep the branch and NOT delete it, this is extremely valuable information.

Thank you again for all your hard work! 🍾

@jiangphcn
Copy link
Contributor Author

THANKS so much for your nice words @wohali. Yes, it is enough painful to get it finally working :-) Again, yes, there are some manual work on that with the steps in this PR. I can work or co-work to make it automate enough, given that this is must. Hope this is not blocking CouchDB 3.0, but want to check how far we can go with non-windows version for CouchDB 3.0.

@wohali wohali merged commit 09740d8 into master Feb 3, 2020
@wohali wohali deleted the build-spidermonkey60 branch February 3, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants