Continued styles and text tidying #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you're reintroducing the bug fixed in #891. You might want to consider rebasing this branch onto master. |
millayr
reviewed
Mar 29, 2017
assets/less/formstyles.less
Outdated
| color: @buttonText; | ||
| background-color: @primaryGreen; | ||
| border-color: @primaryGreen; | ||
| &:disabled, &[disabled]:hover { |
There was a problem hiding this comment.
Minor but my opinion is using pointer-events: none; instead of specifying &[disabled]:hover could be a bit cleaner.
millayr
reviewed
Mar 29, 2017
assets/less/formstyles.less
Outdated
| color: @buttonText; | ||
| background-color: @secondaryBlue; | ||
| border-color: @secondaryBlue; | ||
| &:disabled, &[disabled] { |
There was a problem hiding this comment.
This looks a bit redundant without the :hover. Also consider my suggestion in the previous comment.
millayr
reviewed
Mar 29, 2017
assets/less/formstyles.less
Outdated
| color: @secondaryBlue; | ||
| background-color: @buttonText; | ||
| border: 2px solid @secondaryBlue; | ||
| &:disabled, &[disabled] { |
millayr
reviewed
Mar 29, 2017
assets/less/templates.less
Outdated
| @@ -177,13 +177,12 @@ | |||
| font-weight: normal; | |||
| font-family: helvetica; | |||
| .box-sizing(border-box); | |||
| background-color: #564E4C; | |||
| background-color: @brandDark1 | |||
|
Personal opinion is it'd be nice to have some kind of hover state change (other than a change of cursor) for the database names on the |
millayr
reviewed
Mar 29, 2017
| color: @buttonText; | ||
| background-color: @dangerRed; | ||
| border-color: @dangerRed; | ||
| &:disabled { |
There was a problem hiding this comment.
no need to consider hover state here?
…ibm/couchdb-fauxton into colorclysm-cleanup-couch
garrensmith
approved these changes
Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've edited strings for clarity/consistency in a number of places.
Updated primary/secondary-action buttons to be consistently styled.
Added hover states to a number of buttons that didn't previously have them.
Made some minor style changes (rule colors, heading spacing)
Removed underline effects on links, but maintained hover-color and cursor changes.