Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checksDocsPage tests #1435

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix checksDocsPage tests #1435

merged 1 commit into from
May 22, 2024

Conversation

big-r81
Copy link
Contributor

@big-r81 big-r81 commented May 21, 2024 •
edited

@big-r81 big-r81 requested review from nickva and jaydoane May 22, 2024 00:04
jaydoane
jaydoane approved these changes May 22, 2024
View reviewed changes
Copy link

@jaydoane jaydoane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably put these changes into three separate commits, but otherwise LGTM 👍

@big-r81 big-r81 merged commit c1f9027 into main May 22, 2024
6 checks passed
@big-r81 big-r81 deleted the fix-test-links branch May 22, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaydoane jaydoane jaydoane approved these changes

@nickva nickva Awaiting requested review from nickva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@big-r81 @jaydoane