[Bug fix] Adjust nav bar icon badge placement #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
137
to
146
| .faux-navbar--wide .faux-navbar__icon-badge:after { | ||
| bottom: 12px; | ||
| right: 107px; | ||
| } | ||
|
|
||
| .faux-navbar--narrow .faux-navbar__icon-badge:after { | ||
| bottom: 38px; | ||
| right: 10px; | ||
| } | ||
|
|
There was a problem hiding this comment.
faux-navbar--narrow and faux-navbar--wide are defined around line 46, better to add these extra rules there to keep them together.
Antonio-Maranhao
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The icon badge indicating a new announcement is out of alignment with the nav bar when it is expanded. This change keeps it in the same place relative to the icon, regardless of the nav bar view.
Testing recommendations
Check that the badge stays in place.
GitHub issue number
Related Pull Requests
Checklist