Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle navigation bar icons #1387

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

mharrigan26
Copy link
Contributor

@mharrigan26 mharrigan26 commented Feb 6, 2023

Overview

Restyle the open/close icons in the side navigation bar. The side menu is opened with the menu icon and pushed shut with the same icon overlaid with an arrow. This is more intuitive iconography for the expand/collapse function of the nav bar. New icons generated on https://icomoon.io/app/#/select:

Screenshot 2023-02-23 at 1 15 37 PM

Screenshot 2023-02-23 at 1 15 41 PM

Testing recommendations

Make sure icons appear in nav bar

GitHub issue number

#1257

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • Update rebar.config.script with the correct tag once a new Fauxton release is made

@Antonio-Maranhao
Copy link
Contributor

Antonio-Maranhao commented Feb 21, 2023

Alternative since the nav bar expands as opposed to opening on top of the main content.

image

@Antonio-Maranhao Antonio-Maranhao merged commit 0f65c6f into apache:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants