Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use svgtofont for icon generation #1385

Merged
merged 22 commits into from
Feb 1, 2023

Conversation

mharrigan26
Copy link
Contributor

Overview

Use svgtofont to regenerate icons.
The template and instructions for using this method are in /assets/iconfontgenerator.
Main purpose for this action is that the old icon tool was not maintained, whereas this one is.

Testing recommendations

All changes are cosmetic, so just check to see if all the icons appear correctly.

GitHub issue number

Related Pull Requests

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • Update rebar.config.script with the correct tag once a new Fauxton release is made

assets/icons/arrow-box-up copy.svg Outdated Show resolved Hide resolved
assets/icons/attention-alt copy.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@Antonio-Maranhao Antonio-Maranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Now we can update the icons more easily 🎉
Thank you.

@Antonio-Maranhao Antonio-Maranhao merged commit 8380a1c into apache:main Feb 1, 2023
@mharrigan26 mharrigan26 deleted the svgtofont-testing branch June 27, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants