Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Nightwatch (v1 -> v2) and switch from Travis to GH Actions #1349

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Upgrade Nightwatch (v1 -> v2) and switch from Travis to GH Actions #1349

merged 1 commit into from
Apr 22, 2022

Conversation

fryjordan
Copy link
Contributor

@fryjordan fryjordan commented Apr 21, 2022 •
edited

  • Upgrade Nightwatch from v1 -> v2
  • e2e Selenium tests are currently being run in a Docker container. This is both unnecessary and a nuisance when debugging. This PR includes changes to switch from running Selenium in a Docker container, to locally.
  • There are limitations to using Travis, including free compute limits, and run time duration. As a result, it is preferable to use GitHub Actions. This PR includes changes to move from Travis to Github Actions.

Antonio-Maranhao
Antonio-Maranhao requested changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@Antonio-Maranhao Antonio-Maranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the PR description and title to note you're upgrading to Nightwatch v2 since that's what's driving most of the proposed changes.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tests.md Outdated Show resolved Hide resolved
@fryjordan fryjordan force-pushed the gh-actions branch 2 times, most recently from 5ed726b to 3431373 Compare April 21, 2022 20:00
@fryjordan fryjordan changed the title switch from Travis to GH Actions Upgrade Nightwatch (v1 -> v2) and switch from Travis to GH Actions Apr 21, 2022
@Antonio-Maranhao Antonio-Maranhao merged commit eb90657 into apache:main Apr 22, 2022
@nickva nickva mentioned this pull request Dec 16, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-Maranhao Antonio-Maranhao Antonio-Maranhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fryjordan @Antonio-Maranhao