Set number of databases per page to display #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Antonio-Maranhao Maybe we should store this UI configuration to a cookie/localStorage? People might find it frustrating to change the setting each time they open up Fauxton. |
garrensmith
approved these changes
Jan 8, 2019
| @@ -37,7 +37,9 @@ function deleteDatabase (dbId) { | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
While you here, could you change the ajax to fetch.
| @@ -64,7 +65,7 @@ export class DeleteDatabaseModal extends React.Component { | |||
| onDeleteClick = (e) => { | |||
| e.preventDefault(); | |||
|
|
|||
| Actions.deleteDatabase(this.getDatabaseName()); | |||
| Actions.deleteDatabase(this.getDatabaseName(), this.props.onSuccess); | |||
There was a problem hiding this comment.
I'm kind of torn between rather just returning a promise from the Actions.deleteDatabase and then calling this.props.onSuccess. What do you think?
There was a problem hiding this comment.
I used a callback because that fits better when it's converted to use Redux.
app/addons/databases/actions.js
Outdated
| }); | ||
| }, | ||
|
|
||
| setLimit: function (limit) { |
There was a problem hiding this comment.
tedious but could you remove the function and make it fat arrows.
| @@ -55,6 +77,18 @@ class DatabasesController extends React.Component { | |||
| this.setState(this.getStoreState()); | |||
| }; | |||
|
|
|||
| reloadAfterDatabaseDeleted() { | |||
| let page = this.state.page; | |||
| if (page > 1 && this.state.dbList.length === 1) { | |||
0e0dea6
to
76d2b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows the user to set the number of databases per page.
Testing recommendations
GitHub issue number
#1167
Checklist