Increase the width of string editor modal #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georift
force-pushed
the
doc-editor-ui-improvements
branch
from
3fe66d3
to
aeaf672
Compare
Antonio-Maranhao
requested changes
Oct 19, 2018
assets/less/bootstrap/modals.less
Outdated
| @@ -25,9 +25,8 @@ | |||
| position: fixed; | |||
| top: 10%; | |||
| left: 50%; | |||
| transform: translateX(-50%); | |||
There was a problem hiding this comment.
I'd rather see these overrides in fauxton.less. There's already a section with some in there (search for bootstrap overrides).
I was able to make it work by adding this to fauxton.less:
.modal {
transform: translateX(-50%);
margin-left: inherit;
}
.modal-dialog {
display: flex;
flex-direction: row;
}
.modal-content {
flex: 1;
width: 560px;
}
There was a problem hiding this comment.
Oh sorry, I didn't realise those were bootstrap stylings. I've moved them like you suggested.
Georift
force-pushed
the
doc-editor-ui-improvements
branch
2 times, most recently
from
95d60ac
to
24a5d94
Compare
|
Addressed the changes and removed the |
Moves specified width styling from the parent .modal the .model-content so child models are able to specify their own width. Also removed the modal padding surrounding the text editor. Fixed an issue with mouse pointer not being visible on a few buttons. It was using `cursor: hand` which was supported only supported in very old IE's.
Georift
force-pushed
the
doc-editor-ui-improvements
branch
from
24a5d94
to
d941685
Compare
|
Rebased on master, no code changes. |
|
Hey @Antonio-Maranhao, is there anything else you'd like changed? |
|
Hey @Georift not really. Just didn't have time to take it for a final spin. I'll get to it in a bit. |
Antonio-Maranhao
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When I first used Fauxton I found the default width of the text editor modal (560px) to be a little small. If you were to view the users
validate_doc_updatefunction there would always be an overflow.This PR increases the width of the modal by default and removed the padding surrounding the editor to give it a cleaner look.
Testing recommendations
This change could potentially affect some of the other uses of the modals.
GitHub issue number
No issue number
Checklist