Support fauxton on IE10,IE11 and Edge #1013
Conversation
|
@popojargo @garrensmith |
webpack.config.dev.js
Outdated
| @@ -20,7 +20,7 @@ const settings = require('./tasks/helper') | |||
|
|
|||
| module.exports = { | |||
| entry: { | |||
| bundle: './app/main.js' //Our starting point for our development. | |||
| bundle: ['babel-polyfill','./app/main.js'] //Our starting point for our development. | |||
There was a problem hiding this comment.
To address a previous comment from @garrensmith we could be more granular using core-js and polyfill only what's needed. I was able to launch the UI using bundle: ['core-js/fn/array', 'core-js/fn/symbol', 'core-js/fn/promise', './app/main.js']
There was a problem hiding this comment.
Do you have any idea how I can found which polyfill are missings?
webpack.config.dev.js
Outdated
| @@ -20,7 +20,7 @@ const settings = require('./tasks/helper') | |||
|
|
|||
| module.exports = { | |||
| entry: { | |||
| bundle: './app/main.js' //Our starting point for our development. | |||
| bundle: ['babel-polyfill','./app/main.js'] //Our starting point for our development. | |||
There was a problem hiding this comment.
Side note... webpack.config.release.js needs to be updated as well.
app/addons/activetasks/components.js
Outdated
| @@ -388,8 +388,13 @@ export class ActiveTasksPollingWidgetController extends React.Component { | |||
| state = this.getStoreState(); | |||
|
|
|||
| render() { | |||
| const isIE1X = document.documentMode == 11 || document.documentMode == 10; | |||
There was a problem hiding this comment.
Could you replace with the Helpers.isIE1X() function you created?
|
Btw... @popojargo are you planning on fixing Polling slider as well? If not we should open an issue so we don't lose track of it. |
|
We using Bluebird for promises so we might not need that polyfill.
All misspelling thanks to my iPhone.
…________________________________
From: Antonio Maranhao <[email protected]>
Sent: Thursday, November 2, 2017 7:07:07 PM
To: apache/couchdb-fauxton
Cc: garren smith; Mention
Subject: Re: [apache/couchdb-fauxton] Support fauxton on IE10,IE11 and Edge (#1013)
Btw... @popojargo<https://github.com/popojargo> are you planning on fixing Polling slider as well? If not we should open an issue so we don't lose track of it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1013 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAK9Aup1eQrTMdQq54B0mFYQoWQvEyEPks5syfa6gaJpZM4QOYC0>.
|
|
@Antonio-Maranhao As for the polling, I think it could be for another issue. This is mostly a problem with the mouse events in IE and doesn't have any easy fix so far. |
|
@Antonio-Maranhao I managed to fix the issue for the polling with a package: react-script. The onChange event for range inputs should be fixed on React16(but I can't confirm). |
|
@garrensmith any concerns about the ISC license for |
|
@Antonio-Maranhao ISC is like MIT so it should pass right? |
|
From the list it looks fine https://www.apache.org/legal/resolved.html#category-x
All misspelling thanks to my iPhone.
…________________________________
From: Alexis Côté <[email protected]>
Sent: Tuesday, November 7, 2017 7:55:23 PM
To: apache/couchdb-fauxton
Cc: garren smith; Mention
Subject: Re: [apache/couchdb-fauxton] Support fauxton on IE10,IE11 and Edge (#1013)
@Antonio-Maranhao<https://github.com/antonio-maranhao> ISC is like MIT so it should pass right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1013 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAK9AuVYQm3PaDbDGhDGUyh0U_O4njOQks5s0JmLgaJpZM4QOYC0>.
|
There was a problem hiding this comment.
Great job @popojargo this is awesome. I'll merge once the build passes.
Overview
Testing recommendations
Since we seems to mainly support Firefox and Chrome, there are not automated tests for IE.
With my changes, I fixed:
GitHub issue number
#949
Checklist