Skip to content
This repository has been archived by the owner on Oct 17, 2022. It is now read-only.

[RFC] Background index building in CouchDB 4 #542

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

nickva
Copy link
Contributor

@nickva nickva commented May 13, 2020

This RFC describes how background index building works in CouchDB 4

This RFC describes how background index building works in CouchDB 4
Copy link
Member

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nickva nickva merged commit ecbd992 into master May 13, 2020
@nickva nickva deleted the index-building-rfc branch May 13, 2020 19:38
@wohali
Copy link
Member

wohali commented May 13, 2020

Wow, that got merged very very fast without much review. I would have liked to have at least read this.

Meanwhile we have these FDB RFC PRs that still haven't merged - can we get those landed please, especially if the decisions have been made already?

There is also @janl 's * #424 for per doc access, which is not FDB-specific but the spec is probably ready to go.

@nickva
Copy link
Contributor Author

nickva commented May 13, 2020

@wohali it's because it's a retro-RFC. The implementation itself is easier to read and probably just as long as this RFC, and has been reviewed and merged for a few months already:

apache/couchdb@02ca72b#diff-b008888a90398c4c351fa00ecbef3d48

This was prompted mostly by @garrensmith saying it would be nice to have one, so I added one. But initially debated not having it at all since it's really just "get callback for a db update and trigger couch_jobs". couch_jobs does the heavy lifting here and that has been in review for a long time before it was merged.

We can still comment on it, make pull requests and update it. Thanks for taking a look, btw. I'd be happy to respond and address your comments

@wohali
Copy link
Member

wohali commented May 13, 2020

Cool, well, let's get those others merged please?

I'll review tomorrow and comment if i have comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants