-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarter way to set Cordova platform version number #50
Comments
What does "mark a version" mean exactly? Set the version numbers? |
Yes, just edited title & description to reflect the answer
Yes and I do not find it 100% satisfactory for the following reasons:
My idea is that we can set the desired version number in one place, and the scripts would generate the platform files with the right version numbers whenver the user does |
Cordova platforms historically should also work as packaged downloads without using the CLI, so I think this is not really an option. Looking at why we need those versions in so many places seems like a valid thing to do though. |
NOTE: The version was manually updated in the following files: * RELEASENOTES.md * VERSION * bin/templates/cordova/version * bin/templates/project/assets/www/cordova.js * framework/build.gradle * framework/src/org/apache/cordova/CordovaWebView.java * package.json with help from git & bash tricks based on changes in the following commits for 7.1.2 & 7.1.3-dev versions: - 725e75f - f86519b FUTURE TBD: it is desired that we can set the version in one place as discussed in: apache/cordova#50
NOTE: The version was manually updated in the following files: * RELEASENOTES.md * VERSION * bin/templates/cordova/version * bin/templates/project/assets/www/cordova.js * framework/build.gradle * framework/src/org/apache/cordova/CordovaWebView.java * package.json with help from git & bash tricks based on changes in the following commits for 7.1.2 & 7.1.3-dev versions: - 725e75f - f86519b FUTURE TBD: it is desired that we can set the version in one place as discussed in: apache/cordova#50
I find it really unfortunate that we have to use tooling to set Cordova platform versions in multiple places such as package.json, generated cordova.js, VERSION file, Android Gradle file, etc.
I think it should be relatively straightforward to update the Cordova tooling so that we can mark the version in package.json and the scripts would generate the platform files with the correct version where it is needed whenever the user does
cordova platform add
.And I suspect that in Gradle we should be able to define a constant or variable with the version in one place and reference it in the other places.
The text was updated successfully, but these errors were encountered: