Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(windows) deprecate Windows platform in documentation #1118

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Sep 4, 2020

Status

  • pending formal vote

Platforms affected

Windows

Motivation and Context

see this discussion in [email protected] and apache/cordova-lib#852

Description

  • add a note that Windows platform is now deprecated
  • show "(deprecated)" in TOC title of Windows platform documentation

Testing

Visual inspection

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@brodycj brodycj marked this pull request as draft September 4, 2020 14:02
@purplecabbage purplecabbage marked this pull request as ready for review March 18, 2021 08:13
@purplecabbage
Copy link
Contributor

I don't think this requires a formal vote, the numbers indicate this is a good idea.
I'll leave this open for a few days to gather thumbs up.

@purplecabbage purplecabbage merged commit 2a9ccbf into master Jun 19, 2021
@purplecabbage purplecabbage deleted the brodybits-deprecate-windows branch June 19, 2021 05:16
@brodycj
Copy link
Contributor Author

brodycj commented Jun 24, 2021

Thanks to @purplecabbage for merging these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants