Honour GS use_ext_dns and redundant VR VIP #1536
Conversation
On redundant VR setups, the primary resolver being handed out to instances is the guest_ip (primary IP for the VR). This might lead to problems upon failover, at least while the DHCP lease doesn't update (because the primary resolver will be checked first until times out, however it'll be gone upon failover). If Global Setting use_ext_dns is true, we don't want the VR to be the primary resolver at all.
|
Same as: #1535 but for 4.7 |
|
@swill can we get this in. It's got 2 LGTM and was integration tested on master and monkey tested on 4.7 |
|
LGTM |
|
@ustcweizhou, I suppose it still LGTM to you as well |
|
CI RESULTS: initial fails due to environmental issues all tests passed after rerun: 1536.results.internal_lb.txt |
|
@swill, given that @ustcweizhou gave his ok on #1535, this one can be merged. |
Honour GS use_ext_dns and redundant VR VIPThis patch addresses two issues: On redundant VR setups, the primary resolver being handed out to instances is the guest_ip (primary IP for the VR). This might lead to problems upon failover, at least while the DHCP lease doesn't update (because the primary resolver will be checked first until times out, however it'll be gone upon failover). If Global Setting use_ext_dns is true, we don't want the VR to be the primary resolver at all. * pr/1536: This patch addresses two issues: Signed-off-by: Will Stevens <[email protected]>
|
I just realized this one changes the system vm. Did you deploy a new system VM when you tested this one @DaanHoogland? |
|
It only changes the iso not the template. So what do you mean @swill it is part of the run to create a new iso and use it, right? |
|
So does this change require that we push new system VM templates? |
|
no installing the new iso should do it, but wasn't there already another change that requires a template update? |
|
So far I don't think any of the other changes that have gotten in have required system template changes. Which is why I am asking. There is one that I think is probably ready to get added, but it is a one liner. StrongSwan and OSPF were the big ones that would have required a new system vm template... |
This patch addresses two issues:
On redundant VR setups, the primary resolver being handed out to instances is the guest_ip (primary IP for the VR). This might lead to problems upon failover, at least while the DHCP lease doesn't update (because the primary resolver will be checked first until times out, however it'll be gone upon failover).
If Global Setting use_ext_dns is true, we don't want the VR to be the primary resolver at all.