CPU socket count reporting correction #1520
Conversation
CPU socket count reporting correction From MissionCriticalCloudOldRepos/cosmic-plugin-hypervisor-kvm#16
|
@NuxRo can you do a force push to kick off jenkins and travis again. Also, can you show this change fixes the behavior with a screenshot or something. I don't think the code change warrants a full CI run since nothing new was introduced, only the value of a variable has changed and it uses proper defensive programming... It would be nice to see the problem it solves though... |
|
@swill more details here: MissionCriticalCloudOldRepos/cosmic-plugin-hypervisor-kvm#16 |
|
Great, thanks @remibergsma. :) |
|
@NuxRo thanks, please rebase and squash to a single commit LGTM tag:mergeready |
|
I'd appreciate it if someone else could do it, I do not have the setup to perform more advanced github operations right now, other than the UI. |
|
Can we get another code review on this? Also, Jenkins seems to be hung, can we either close and reopen the PR or do a force push to kick it off? Thx... |
|
We have rolled this patch in our lab and verified that it does indeed report the number of sockets correctly. Based on testing this LGTM. Please do a force push to kick off jenkins and travis again. |
|
LGTM (code review) tag:mergeready |
|
I am comfortable not running CI on this one given the scope of the change and the manual tests that have been run. This one is ready now. We need this force pushed again though so we can get Jenkins green. Thx... |
|
@NuxRo can you close and reopen this PR to force Jenkins to kick off a run. It has been hung in this state for days. I know you can't easily |
|
@NuxRo I have pushed fixes to both Jenkins and Travis this morning. Can you close and reopen the PR to kick off the Jenkins and Travis runs again. Thanks... |
|
LGTM, running this in prod for about a month now. See link above for screenshots. |
|
@swill This one is green now. |
|
Awesome, thanks guys. I will merge this... |
CPU socket count reporting correctionCPU socket count reporting correction From MissionCriticalCloudOldRepos/cosmic-plugin-hypervisor-kvm#16 * pr/1520: Remove empty spaces causing the build to fail CPU socket count reporting correction Signed-off-by: Will Stevens <[email protected]>
CPU socket count reporting correction
From MissionCriticalCloudOldRepos/cosmic-plugin-hypervisor-kvm#16