CLOUDSTACK-9172 Added cross zones check to delete template and iso #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a UI change, is it possible to supply screenshots to show this behaves as expected? For UI changes we tend to use visual proof since we can't do CI. Thanks... |
|
tested with 4.7.2 + swift as Secondary Storage. with Swift,zoneid of template is empty. this should go in master too. LGTM. |
|
Screen shot from before the fix After: |
|
Thank you sir. This is looking pretty good now. I think this LGTM, so I will add this to the PRs to be merged today. |
asfgit
pushed a commit
that referenced
this pull request
Apr 21, 2016
…s-template CLOUDSTACK-9172 Added cross zones check to delete template and isoAdded a check to ignore the zoneid, in the delete template UI, if the template is cross zones. reference : CLOUDSTACK-9172 * pr/1505: CLOUDSTACK-9172 Added cross zones check to delete template and iso Signed-off-by: Will Stevens <[email protected]>
GaOrtiga
pushed a commit
to scclouds/cloudstack
that referenced
this pull request
Apr 25, 2024
…scclouds' Normalização da consolidação de volumes na migração à quente Closes apache#1505 See merge request scclouds/scclouds!751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to ignore the zoneid, in the delete template UI, if the template is cross zones.
reference : CLOUDSTACK-9172