-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDSTACK-9299: Out-of-band Management for CloudStack #1502
Conversation
497906b
to
f76ab8e
Compare
a77a527
to
6b03133
Compare
} | ||
|
||
private void validateParams() { | ||
if (getHostId() == null || getHostId() < 1L) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove validateParams() as soon as dynamic-roles gets merged to master, I'll rebase this PR and use the new validations annotations field.
a60d38b
to
d614c70
Compare
Pinging for review @jburwell @swill @wido @pyr @koushik-das @agneya2001 @DaanHoogland @rafaelweingartner @GabrielBrascher @kishankavala |
/////////////// API Implementation/////////////////// | ||
///////////////////////////////////////////////////// | ||
|
||
private void validateParams() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pity your new Annotation parameter for @parameter, validators is not in yet.
@DaanHoogland thanks, @borisstoyanov will share QA results next week as well |
Thanks guys. I will try to get this one queued up for CI. |
Really exciting PR @bhaisaab! We'll pull this in for testing as well. |
Thanks @swill @kiwiflyer |
@swill I am running the tests on this one. You want to both run it or beat me at it? |
First read-through didn't raise any eyebrows on my end. LGTM |
Perfect thanks @DaanHoogland. Once we get more people using bubble, maybe we can start posting to the PR that we are kicking off a CI run (like you did here) so we can be sure to best use our limited resources. I have been helping @kiwiflyer and @dmabry get bubble setup in their environment and I think they are all set now, so they will likely be contributing to this effort as well. |
8358778
to
343a08f
Compare
} finally { | ||
if (Strings.isNullOrEmpty(stdError)) { | ||
stdOutput = readStream(process.getInputStream()); | ||
stdError = readStream(process.getErrorStream()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered using Guava's CharStreams.toString(new BufferedWriter(process.getErrorStream))
instead of readStream
?
f6ae5fa
to
6aa0fbd
Compare
@jburwell can you do a final review, LGTM or share further improvements. Thanks. |
6aa0fbd
to
87d5099
Compare
@nvazquez can you check why test_03_list_snapshots failed in the Travis run, with tearDown exception. |
@swill PR1539 passed Jenkins and Travis. After you merge it should resolve the issue in other PRs |
Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, DRAC, etc.) to manage host power operations (on/off etc.) and querying current power state in CloudStack. Given the wide range of out-of-band management interfaces such as iLO and iDRA, the service implementation allows for development of separate drivers as plugins. This feature comes with a ipmitool based driver that uses the ipmitool (https://linux.die.net/man/1/ipmitool) to communicate with any out-of-band management interface that support IPMI 2.0. This feature allows following common use-cases: - Restarting stalled/failed hosts - Powering off under-utilised hosts - Powering on hosts for provisioning or to increase capacity - Allowing system administrators to see the current power state of the host For testing this feature `ipmisim` can be used: https://pypi.python.org/pypi/ipmisim FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack Signed-off-by: Rohit Yadav <[email protected]>
- For out-of-band management feature (CLOUDSTACK-9299) use patched version of ipmitool that would work on trusty travis machines - The ipmitool used is from xenial/16.04 release with patch from RedHat https://bugzilla.redhat.com/show_bug.cgi?id=1286035 - Installs ipmitool from xenial repositories to get all the dependencies and then install patched deb version - Skip test if the known failure occurs Signed-off-by: Rohit Yadav <[email protected]>
Increases timeout to a larger value to avoid failures in VM environments such as TravisCI. Signed-off-by: Rohit Yadav <[email protected]>
Reorder cleanup items so cleanup won't fail Signed-off-by: Rohit Yadav <[email protected]>
66e7873
to
6135f6d
Compare
This fixes several Jenkins failures as previous runs don't cleanup this file created by one of the unit tests. Signed-off-by: Rohit Yadav <[email protected]>
tag:mergeready /cc @swill all green now |
CLOUDSTACK-9299: Out-of-band Management for CloudStackSupport access to a hosts out-of-band management interface (e.g. IPMI, iLO, DRAC, etc.) to manage host power operations (on/off etc.) and querying current power state in CloudStack. Given the wide range of out-of-band management interfaces such as iLO and iDRA, the service implementation allows for development of separate drivers as plugins. This feature comes with a ipmitool based driver that uses the ipmitool (https://linux.die.net/man/1/ipmitool) to communicate with any out-of-band management interface that support IPMI 2.0. This feature allows following common use-cases: - Restarting stalled/failed hosts - Powering off under-utilised hosts - Powering on hosts for provisioning or to increase capacity - Allowing system administrators to see the current power state of the host For testing this feature, please install `ipmitool` (using yum/apt/brew) and `ipmisim`: https://pypi.python.org/pypi/ipmisim The default ipmitool location is assumed in /usr/bin, if this is different in your env please fix the global setting, see FS for details on various global settings. FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack /cc @jburwell @swill @abhinandanprateek @murali-reddy @borisstoyanov * pr/1502: maven: ignore utils/testsmallfileinactive for rat checking CLOUDSTACK-9378: Fix for #1497 HypervisorUtilsTest: increate timeout to 8seconds travis: Use patched version of ipmitool for tests CLOUDSTACK-9299: Out-of-band Management for CloudStack Signed-off-by: Will Stevens <[email protected]>
I see the following error which is causing the PR #1297 to fail. Suggestions?
More details:
|
Jenkins for #1537 is also being held up by these tests:
|
@swill thanks, will have a look at it |
Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
DRAC, etc.) to manage host power operations (on/off etc.) and querying current
power state in CloudStack.
Given the wide range of out-of-band management interfaces such as iLO and iDRA,
the service implementation allows for development of separate drivers as plugins.
This feature comes with a ipmitool based driver that uses the
ipmitool (https://linux.die.net/man/1/ipmitool) to communicate with any
out-of-band management interface that support IPMI 2.0.
This feature allows following common use-cases:
For testing this feature, please install
ipmitool
(using yum/apt/brew) andipmisim
:https://pypi.python.org/pypi/ipmisim
The default ipmitool location is assumed in /usr/bin, if this is different in your env please fix the global setting, see FS for details on various global settings.
FS:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
/cc @jburwell @swill @abhinandanprateek @murali-reddy @borisstoyanov