writeIfNotHere requires an array of strings, not a string

[hogniRunar]

No description provided.

[pdube]

Hi @hogniRunar,

The code change LGTM. I verified for references to the function, but did not test it. Could you create a JIRA ticket for it please? Could you also add some information as to how do you reproduce the error, and how to test the fix?

Thanks

[hogniRunar]

To reproduce it you just need to set up a basic baremetal zone, start an instance and on the bootserver for baremetal you can look at /var/www/html/metadata//meta-data. As for testing I am not sure what would be the best way other than looking at that same file once the fix has been implemented.

Ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-9330

[swill]

CI RESULTS

Tests Run: 85
  Skipped: 0
   Failed: 1
   Errors: 0
 Duration: 4h 19m 54s

Summary of the problem(s):

FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
    "Attempt to retrieve google.com index page should be successful once rule is added!"
AssertionError: Attempt to retrieve google.com index page should be successful once rule is added!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_MVU2HC/results.txt

Associated Uploads

/tmp/MarvinLogs/DeployDataCenter__May_12_2016_05_55_59_X571TZ:

• dc_entries.obj
• failed_plus_exceptions.txt
• runinfo.txt

/tmp/MarvinLogs/test_network_MVU2HC:

• failed_plus_exceptions.txt
• results.txt
• runinfo.txt

/tmp/MarvinLogs/test_vpc_routers_9QM5ZD:

• failed_plus_exceptions.txt
• results.txt
• runinfo.txt

Uploads will be available until 2016-07-12 02:00:00 +0200 CEST

Comment created by upr comment.

[swill]

Can I get another code review so this can be merged?

[DaanHoogland]

LGTM