Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSANDRA-18078 trunk: Remove maxwritetime function #2032

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

CASSANDRA-18078 trunk: Remove maxwritetime function #2032

wants to merge 3 commits into from

Conversation

adelapena
Copy link
Contributor

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

frankgh
frankgh reviewed Nov 29, 2022
View reviewed changes
Copy link
Contributor

@frankgh frankgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but it looks good to me

CHANGES.txt Outdated
@@ -80,7 +80,6 @@
* Add guardrail to allow disabling of SimpleStrategy (CASSANDRA-17647)
* Change default directory permission to 750 in packaging (CASSANDRA-17470)
* Adding support for TLS client authentication for internode communication (CASSANDRA-17513)
* Add new CQL function maxWritetime (CASSANDRA-17425)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add a new line mentioning the removal of the CQL function instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. If we take this file as a record of code changes, it makes sense to keep the removed line and add a new one about the removal of the function. If we take this file as a list of what is different from previous release, then having both entries only adds noise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intuition is that CHANGES is append-only.. Also quoting from https://cassandra.apache.org/_/development/index.html

Please note that only user-impacting items should be listed in CHANGES.txt.

Removing a function is user impacting.

test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeWritetimeOrTTLTest.java Outdated
@@ -73,25 +74,23 @@ public void testWritetimeOrTTLDuringUpgrade() throws Throwable

private void assertPre42Behaviour(ICoordinator coordinator)
{
// regular column, supported except for maxwritetime
// regular column, supported except for max writetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeWritetimeOrTTLTest.java Outdated
Assertions.assertThat((Integer) coordinator.execute(withKeyspace("SELECT ttl(v) FROM %s.t"), ALL)[0][0])
.isLessThanOrEqualTo(2000).isGreaterThan(2000 - 300); // margin of error of 5 minutes since TTLs decrease

// frozen collection, supported except for maxwritetime
// frozen collection, supported except for max writetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update this comment as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

smiklosovic
smiklosovic reviewed Jun 21, 2024
View reviewed changes
src/java/org/apache/cassandra/cql3/functions/CollectionFcts.java
@Override
public ByteBuffer execute(ProtocolVersion protocolVersion, List<ByteBuffer> parameters)
{
return parameters.get(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not work in current 5.0 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smiklosovic smiklosovic smiklosovic left review comments

@frankgh frankgh frankgh left review comments

@yifan-c yifan-c yifan-c left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@adelapena @smiklosovic @frankgh @yifan-c