Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove additional custom labels utility #4184

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Remove additional custom labels utility #4184

merged 1 commit into from
Mar 29, 2023

Conversation

claudio4j
Copy link
Contributor

Fix #4183

Release Note

Remove custom labels from build time

@claudio4j claudio4j force-pushed the ups_main_remove_metering_labels branch from bd57be7 to 211c98a Compare March 28, 2023 21:57
squakez
squakez requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to remove the references in the Makefile as well. Also, bear in mind those flags are used by make bundle, so, we need to adjust it and make sure they are no longer used.

@claudio4j
Copy link
Contributor Author

Make sure to remove the references in the Makefile as well. Also, bear in mind those flags are used by make bundle, so, we need to adjust it and make sure they are no longer used.

the labels package is not in use in Makefile or scripts in upstream.

@claudio4j claudio4j merged commit 865ebdb into apache:main Mar 29, 2023
@claudio4j claudio4j deleted the ups_main_remove_metering_labels branch March 29, 2023 12:57
claudio4j added a commit to claudio4j/camel-k that referenced this pull request Mar 29, 2023
@claudio4j
Remove additional custom labels utility (apache#4184)
24da21c 
(cherry picked from commit 865ebdb)
claudio4j added a commit to claudio4j/camel-k that referenced this pull request Mar 29, 2023
@claudio4j
Remove additional custom labels utility (apache#4184)
2c8b328 
(cherry picked from commit 865ebdb)
claudio4j added a commit to claudio4j/camel-k that referenced this pull request Mar 29, 2023
@claudio4j
Remove additional custom labels utility (apache#4184)
f038d88 
(cherry picked from commit 865ebdb)
claudio4j added a commit to claudio4j/camel-k that referenced this pull request Mar 29, 2023
@claudio4j
Remove additional custom labels utility (apache#4184)
a175dde 
(cherry picked from commit 865ebdb)
claudio4j added a commit that referenced this pull request Mar 30, 2023
@claudio4j
Remove additional custom labels utility (#4184) (#4187)
d95d7af 
(cherry picked from commit 865ebdb)
claudio4j added a commit that referenced this pull request Mar 30, 2023
@claudio4j
Remove additional custom labels utility (#4184) (#4188)
d99b906 
(cherry picked from commit 865ebdb)
squakez pushed a commit to jboss-fuse/camel-k that referenced this pull request Mar 30, 2023
@claudio4j @github-actions
Remove additional custom labels utility (apache#4184) (apache#4187)
3d6468e 
(cherry picked from commit 865ebdb)

(cherry picked from commit apache/camel-k@d95d7af8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez requested changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove additional custom labels utility
3 participants
@claudio4j @oscerd @squakez