-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIGTOP-3950: fix ranger etc conf dir #1120
Conversation
@kevinw66 Could you kindly help review this ranger PR, please? |
@kevinw66 |
@guyuqi Could you kindly help review this ranger PR, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test the build:
[root@8b192978c355 ws]# . /etc/profile.d/bigtop.sh ; ./gradlew ranger-clean ranger-pkg
...
[root@8b192978c355 ws]# for i in $(ls output/ranger/x86_64); do rpm -qlpv output/ranger/x86_64/$i; echo; done | grep /etc
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/admin
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/admin/conf.dist
-rwxr-xr-x 1 ranger ranger 5283 Jun 25 06:11 /etc/ranger/admin/conf.dist/logback.xml
-rwxr-xr-x 1 ranger ranger 16639 Jun 25 06:11 /etc/ranger/admin/conf.dist/ranger-admin-default-site.xml
-rwxr-xr-x 1 ranger ranger 10258 Jun 25 06:11 /etc/ranger/admin/conf.dist/ranger-admin-site.xml
-rwxr-xr-x 1 ranger ranger 7602 Jun 25 06:11 /etc/ranger/admin/conf.dist/security-applicationContext.xml
lrwxrwxrwx 1 root root 22 Jun 25 06:11 /usr/lib/ranger-admin/conf -> /etc/ranger/admin/conf
lrwxrwxrwx 1 root root 22 Jun 25 06:11 /usr/lib/ranger-admin/ews/webapp/WEB-INF/classes/conf -> /etc/ranger/admin/conf
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/kms
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/kms/conf.dist
-rwxr-xr-x 1 ranger ranger 12855 Jun 25 06:11 /etc/ranger/kms/conf.dist/dbks-site.xml
-rwxr-xr-x 1 ranger ranger 3301 Jun 25 06:11 /etc/ranger/kms/conf.dist/kms-logback.xml
-rwxr-xr-x 1 ranger ranger 5977 Jun 25 06:11 /etc/ranger/kms/conf.dist/kms-site.xml
-rwxr-xr-x 1 ranger ranger 1990 Jun 25 06:11 /etc/ranger/kms/conf.dist/ranger-kms-site.xml
lrwxrwxrwx 1 root root 20 Jun 25 06:11 /usr/lib/ranger-kms/conf -> /etc/ranger/kms/conf
lrwxrwxrwx 1 root root 20 Jun 25 06:11 /usr/lib/ranger-kms/ews/webapp/WEB-INF/classes/conf -> /etc/ranger/kms/conf
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/tagsync
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/tagsync/conf.dist
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/tagsync/conf.dist/etc
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/tagsync/conf.dist/etc/ranger
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/tagsync/conf.dist/etc/ranger/data
-rwxr-xr-x 1 ranger ranger 1143 Jun 25 06:11 /etc/ranger/tagsync/conf.dist/etc/ranger/data/tags.json
-rwxr-xr-x 1 ranger ranger 1632 Jun 25 06:11 /etc/ranger/tagsync/conf.dist/logback.xml
-rwxr-xr-x 1 ranger ranger 883 Jun 25 06:11 /etc/ranger/tagsync/conf.dist/ranger-tagsync-env-setup-hadoop-home.sh
lrwxrwxrwx 1 root root 24 Jun 25 06:11 /usr/lib/ranger-tagsync/conf -> /etc/ranger/tagsync/conf
drwxr-xr-x 2 root root 0 Jun 25 06:11 /usr/lib/ranger-tagsync/conf.dist/etc
drwxr-xr-x 2 root root 0 Jun 25 06:11 /usr/lib/ranger-tagsync/conf.dist/etc/ranger
drwxr-xr-x 2 root root 0 Jun 25 06:11 /usr/lib/ranger-tagsync/conf.dist/etc/ranger/data
-rw-r--r-- 1 root root 1143 Jun 25 06:11 /usr/lib/ranger-tagsync/conf.dist/etc/ranger/data/tags.json
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/usersync
drwxr-xr-x 2 ranger ranger 0 Jun 25 06:11 /etc/ranger/usersync/conf.dist
-rwxr-xr-x 1 ranger ranger 1671 Jun 25 06:11 /etc/ranger/usersync/conf.dist/logback.xml
-rwxr-xr-x 1 ranger ranger 2189 Jun 25 06:11 /etc/ranger/usersync/conf.dist/ranger-ugsync-default.xml
lrwxrwxrwx 1 root root 25 Jun 25 06:11 /usr/lib/ranger-usersync/conf -> /etc/ranger/usersync/conf
I'm not sure if the owner permissions for /usr/lib/ranger-*
is correct, or whether should we change the directory structure to /usr/lib/ranger/*
also, but conf dir looks good to me.
LGTM |
merged, thanks @JiaLiangC |
Description of PR
This PR modifies the configuration directories for Ranger Admin, Ranger Tag Sync, and Ranger User Sync from
/etc/ranger-admin
,/etc/ranger-tagsync
, and/etc/ranger-usersync
to/etc/ranger/{admin,tagsync,usersync}
. The detailed reason for this change can be found in the following issue: https://issues.apache.org/jira/projects/BIGTOP/issues/BIGTOP-3950How was this patch tested?
manual test
before fix, ranger-tagsync can't start,because it ranger can't found /etc/ranger/tagsync/logback.xml
after fix , ranger-tagsync works smoonthly
![image](https://private-user-images.githubusercontent.com/18082602/245971408-33b402b1-d6b6-45e8-9946-c8c741d90b7d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2ODcwMTUsIm5iZiI6MTcyNDY4NjcxNSwicGF0aCI6Ii8xODA4MjYwMi8yNDU5NzE0MDgtMzNiNDAyYjEtZDZiNi00NWU4LTk5NDYtYzhjNzQxZDkwYjdkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDE1MzgzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY0ODAzODk2ODRkNDQ0YzIzYjljYTdlODgzZThjNzJiMzFkN2FjODMwNGY3ODAyZWMxZTAyYjBkYzc3NzJjZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VcFr4e4u7iRDWRawS6yRv53a0H2JFV6WxwcnhdLGx-c)
![image](https://private-user-images.githubusercontent.com/18082602/245971468-8073b76a-274e-480c-a554-d862a774311b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2ODcwMTUsIm5iZiI6MTcyNDY4NjcxNSwicGF0aCI6Ii8xODA4MjYwMi8yNDU5NzE0NjgtODA3M2I3NmEtMjc0ZS00ODBjLWE1NTQtZDg2MmE3NzQzMTFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDE1MzgzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIzZjYyODkwNjA5N2IzNWQxZmU0YTljOWNjMTc4YjgzMWY5M2I4MGU1ODE3MTBjMmU4MTQyMDBhNzg5MTcyMDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nj9njwdFwVk5w3V0i74DAtejICP1JEgJSZJ6mzIbiaU)
For code changes: