Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-3786: Improve the build scripts to append suffix to the rpm package name #1058

Merged
merged 11 commits into from
Dec 5, 2022

Conversation

timyuer
Copy link
Contributor

@timyuer timyuer commented Nov 26, 2022

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
  • Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@timyuer
Copy link
Contributor Author

timyuer commented Nov 26, 2022

Tested success by . /etc/profile.d/bigtop.sh; ./gradlew zookeeper-clean zookeeper-pkg -PpkgSuffix -PparentDir=/usr/bigtop in Centos7(x86_64).
1669463441728

Tested success by . /etc/profile.d/bigtop.sh; ./gradlew zookeeper-clean zookeeper-pkg in Centos7(x86_64).
1669463678205

@timyuer
Copy link
Contributor Author

timyuer commented Nov 26, 2022

Tested success by . /etc/profile.d/bigtop.sh ; ./gradlew bigtop-select-clean bigtop-select-pkg -PpkgSuffix in Centos7(x86_64).
1669463728680

@timyuer timyuer changed the title BIGTOP-3786: Improve the build scripts to append suffix to the package name [WIP] BIGTOP-3786: Improve the build scripts to append suffix to the package name Nov 26, 2022
@timyuer timyuer changed the title [WIP] BIGTOP-3786: Improve the build scripts to append suffix to the package name BIGTOP-3786: Improve the build scripts to append suffix to the package name Nov 29, 2022
@timyuer timyuer changed the title BIGTOP-3786: Improve the build scripts to append suffix to the package name BIGTOP-3786: Improve the build scripts to append suffix to the rpm package name Nov 29, 2022
@timyuer
Copy link
Contributor Author

timyuer commented Nov 30, 2022

Tested successful for Ambari (Ambari-trunk, Centos7).

@kevinw66
Copy link
Contributor

Build success on RockyLinux 8 without suffix

. /etc/profile.d/bigtop.sh ; ./gradlew allclean zookeeper-pkg kafka-pkg flink-pkg hadoop-pkg hbase-pkg hive-pkg solr-pkg spark-pkg tez-pkg zeppelin-pkg

image

@timyuer
Copy link
Contributor Author

timyuer commented Nov 30, 2022

When modifying spark, I added the spark rpm package to ensure the consistency of the format. All contents except components are stored in the spark RPM package. The spark-core only contains README.md and sets the dependency relationship to spark-master -> spark-core -> spark -> hadoop-yarn.
Is there any problem with that?

@kevinw66
Copy link
Contributor

Build success on RockyLinux8 with suffix

. /etc/profile.d/bigtop.sh ; ./gradlew allclean spark-pkg zookeeper-pkg kafka-pkg flink-pkg hadoop-pkg hbase-pkg hive-pkg solr-pkg tez-pkg zeppelin-pkg -PpkgSuffix

image

@guyuqi
Copy link
Member

guyuqi commented Dec 5, 2022

@timyuer
Would any other commits be added to this PR?

@timyuer
Copy link
Contributor Author

timyuer commented Dec 5, 2022

@timyuer Would any other commits be added to this PR?

No.

@guyuqi
Copy link
Member

guyuqi commented Dec 5, 2022

@timyuer Would any other commits be added to this PR?

No.

Thanks. LGTM +1.

As talked with @kevinw66 , I'd like merge this to master.
Because bigtop-select is just only used for Ambari-2.8 and it only supports RPMs in Bigtop, I would disable the component bigtop-select in Bigtop-3.2 (Branch-3.2).
Ambari guys could fetch our Bigtop-3.2 release source code and enbale bigtop-select component by themselves.

@guyuqi guyuqi merged commit 650b2e5 into apache:master Dec 5, 2022
eubnara pushed a commit to eubnara/bigtop that referenced this pull request Mar 11, 2023
…ckage name (apache#1058)

Append suffix for Kafka, solr, hive, hbase, tez, flink, spark, zeppelin, hadoop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants