Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove --flink-master-url alias." #9947

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Conversation

robertwb
Copy link
Contributor

This reverts commit 1ccecd3.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@tweise
Copy link
Contributor

tweise commented Oct 31, 2019

The alias is needed. Looks like we are spinning wheels. Please allow for appropriate review.

@tweise
Copy link
Contributor

tweise commented Oct 31, 2019

Run Python2_PVR_Flink PreCommit

@tweise tweise merged commit 18b63e4 into apache:master Oct 31, 2019
@tweise
Copy link
Contributor

tweise commented Oct 31, 2019

Merging this the alias is required for backward compatibility.

@mxm
Copy link
Contributor

mxm commented Oct 31, 2019

For reference: We just renamed flink-master-url to flink-master for consistency, but we made flink-master-url an alias to ensure backwards-compatibility, because this parameter has been used for more than a year. See also: https://github.com/apache/beam/pull/9844/files#diff-e52a25378b181af8cecbf3d274946fd0R43

@robertwb
Copy link
Contributor Author

Yes. This PR puts things back into the state they were. Looks like we're stuck with the alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants