Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beam-2535] : Support outputTimestamp and watermark holds in timers. #9677

Merged
merged 59 commits into from
Jan 8, 2020
Merged

[Beam-2535] : Support outputTimestamp and watermark holds in timers. #9677

Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
329c2e6
Beam-2535 : Pursue pull request 4700 with manual apply changes from c…
xubii Sep 27, 2019
f72a29a
Beam-2535 : Pursue pull request 4700 with manual apply changes from c…
xubii Sep 27, 2019
fd72944
Merge https://github.com/apache/beam into time-output-timestamp
xubii Sep 27, 2019
81621be
Beam-2535 : Pursue pull request 4700 with manual apply changes from c…
xubii Sep 27, 2019
5249dd1
Beam-2535 : Replace timeStamp with outputTimeStamp
xubii Oct 15, 2019
cab84c2
Beam-2535 : Apply Spotless
xubii Oct 16, 2019
b0eb6f8
Merge branch 'master' into time-output-timestamp
xubii Oct 18, 2019
5aeeebf
Beam-2535 : Pass outputTimestamp param in onTimer method
xubii Oct 18, 2019
9926a01
Beam-2535 : Minor changed
xubii Oct 18, 2019
6f16562
[BEAM-2535] : Add Commit State in ParDoEvaluator
Oct 23, 2019
1839319
Merge branch 'master' into time-output-timestamp
Oct 23, 2019
a8c65b8
[BEAM-2535] : Add outputTimestamp in compare method, Revert StatefulP…
Oct 23, 2019
b398447
Beam-2535 : Modifying default minimum target and GC time
xubii Oct 24, 2019
03625c9
Merge branch 'master' into time-output-timestamp
xubii Oct 24, 2019
dffea11
BEAM-2535 : Removal of extra lines
Oct 25, 2019
0b5e231
Beam-2535 : Proposed changes
xubii Oct 31, 2019
47dce8a
Merge branch 'master' into time-output-timestamp
xubii Oct 31, 2019
da3001a
Merge branch 'time-output-timestamp' of https://github.com/xubii/beam…
xubii Oct 31, 2019
d5a8b2d
Beam-2535 : Added original PR watermark hold functionality.
xubii Nov 11, 2019
6e9ca40
Merge branch 'master' into time-output-timestamp
Nov 11, 2019
71fbf10
[BEAM-2535] Apply Spotless
Nov 11, 2019
bacccdc
[Beam-2535] Variable renaming and added output timestamp in BufferedE…
xubii Nov 18, 2019
b61b565
Merge branch 'master' into time-output-timestamp
xubii Nov 18, 2019
cfa678e
Beam-2535 : Apply Spotless
xubii Nov 18, 2019
8f02a43
Merge branch 'time-output-timestamp' of https://github.com/xubii/beam…
xubii Nov 18, 2019
11cbc0c
[Beam-2535] Modify test case
xubii Nov 19, 2019
f10ba3f
[Beam-2535] Added comments
xubii Nov 19, 2019
6d04941
Merge branch 'master' into time-output-timestamp
xubii Nov 19, 2019
66eacdd
[Beam-2535] Apply Spotless
xubii Nov 19, 2019
b29e04b
[Beam-2535] Set Processing Time with outputTimestamp
xubii Nov 19, 2019
f85b889
[Beam-2535] Minor renaming
xubii Nov 19, 2019
7835912
[BEAM-2535] Revert Processing Time, Addition of OutputTimestamp
Nov 20, 2019
ee8a7f3
Merge branch 'master' into time-output-timestamp
Nov 20, 2019
1bea195
[BEAM-2535] Revert TimerReceiver outputTimestamp
Nov 20, 2019
e540266
[BEAM-2535] Revert TimerReceiver outputTimestamp
Nov 21, 2019
97c59de
Merge branch 'master' into time-output-timestamp
Nov 21, 2019
9713ce0
Merge branch 'master' into time-output-timestamp
Nov 25, 2019
c1e284b
[BEAM-2535] Making OnTimer compatible
Nov 25, 2019
a3134ba
[BEAM-2535] Making OnTimer compatible
Nov 25, 2019
396c89b
Adding OutputTimestamp in Timer Object
Nov 27, 2019
0822c4e
Merge branch 'master' into time-output-timestamp
Nov 27, 2019
7b386bf
Apply Spotless and checkstyle
Nov 27, 2019
c273b53
[Beam-2535] Added watermark functionality for the dataflow runner
xubii Nov 28, 2019
742d0bb
Merge branch 'master' into time-output-timestamp
xubii Nov 28, 2019
259c63c
[Beam-2535] Used boolean instead boxed type
xubii Dec 3, 2019
e43547c
Merge branch 'master' into time-output-timestamp
xubii Dec 3, 2019
1950ad9
[Beam-2535] Modify required watermark hold functionality
xubii Dec 4, 2019
465fa57
EarliestTimestamp Fix for outputTimestamp
Dec 18, 2019
a94327b
Merge branch 'master' into time-output-timestamp
Dec 18, 2019
21539d5
Merge branch 'master' into time-output-timestamp
Dec 24, 2019
7c8369d
Merge branch 'master' into time-output-timestamp
Dec 30, 2019
83d90fd
Rebase TimerData PR
Dec 30, 2019
7d60044
Update ParDoTest.java
reuvenlax Jan 8, 2020
2565959
Merge master into time-output-timestamp
Jan 8, 2020
2ea7bab
Apply spotless
Jan 8, 2020
5e63afd
Compilation Fix PardoTest
Jan 8, 2020
80862f2
Reverting outputTimestamp validation
Jan 8, 2020
149dec2
CheckStyle Fix
Jan 8, 2020
6fdb1e1
Adding Category to exclude Flink Runner
Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Beam-2535 : Pass outputTimestamp param in onTimer method
  • Loading branch information
@xubii
xubii committed Oct 18, 2019
commit 5aeeebf37014cff0f3c592d0896d05f6d7235d7b
7 changes: 6 additions & 1 deletion ...ava/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,12 @@ private static void advanceInputWatermark(
StateNamespace namespace = timer.getNamespace();
checkArgument(namespace instanceof StateNamespaces.WindowNamespace);
BoundedWindow window = ((StateNamespaces.WindowNamespace) namespace).getWindow();
toTrigger.onTimer(timer.getTimerId(), window, timer.getTimestamp(), timer.getDomain());
toTrigger.onTimer(
timer.getTimerId(),
window,
timer.getTimestamp(),
timer.getOutputTimestamp(),
timer.getDomain());
}
}

Expand Down