[BEAM-7616] Cherry Pick #8925 to release branch #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[BEAM-7616] Add a timeout to urlopen calls
|
Integration tests seems to be failing. Do we have the dataflow containers ready in the branch? That might be the cause. |
|
No, haven't built the containers yet. I am trying to build the branch locally first before I do further steps, it fails in couple of places so far (:beam-test-tools fails to build and the spotbugs hangs for couple of projects). Might do the containers instead if can't get unblocked for the tasks I am working on |
|
Ack. Please ping me when it is ready, I can re-run the tests at that point. (Or if you prefer you can merge this before that, since change is 1-line and tested in master already.0 |
|
running the precommit manually: https://builds.apache.org/job/beam_PreCommit_Python_Commit/7389/ |
|
Python precommit succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-7616] Add a timeout to urlopen calls
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.