Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-7603] Support for ValueProvider-given GCS Location for WriteToBigQuery w File Loads #8908

Merged
merged 8 commits into from
Jul 11, 2019
Merged

[BEAM-7603] Support for ValueProvider-given GCS Location for WriteToBigQuery w File Loads #8908

merged 8 commits into from
Jul 11, 2019

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Jun 20, 2019

No description provided.

@pabloem
Copy link
Member Author

pabloem commented Jun 20, 2019 •
edited
Loading

#8833 is the original PR to master.

@akedin

@pabloem
Copy link
Member Author

pabloem commented Jun 20, 2019

Run Python PreCommit

@akedin
Copy link
Contributor

akedin commented Jun 20, 2019

run python precommit

@akedin
Copy link
Contributor

akedin commented Jun 20, 2019

Run Python PreCommit

@akedin
Copy link
Contributor

akedin commented Jun 20, 2019

run python precommit

5 similar comments
@akedin
Copy link
Contributor

akedin commented Jun 20, 2019

run python precommit

@akedin
Copy link
Contributor

akedin commented Jun 20, 2019

run python precommit

@akedin
Copy link
Contributor

akedin commented Jun 20, 2019

run python precommit

@akedin
Copy link
Contributor

akedin commented Jun 20, 2019

run python precommit

@akedin
Copy link
Contributor

akedin commented Jun 20, 2019

run python precommit

@pabloem
Copy link
Member Author

pabloem commented Jun 21, 2019

The failures look suspicious to me. Maybe related to recreating some containers?

@pabloem
Copy link
Member Author

pabloem commented Jun 25, 2019

Run Python PreCommit

1 similar comment
@chamikaramj
Copy link
Contributor

Run Python PreCommit

@chamikaramj
Copy link
Contributor

@tvalentyn any idea about the ':sdks:python:test-suites:tox:py37:testPython37'. failure on the release branch ?
https://builds.apache.org/job/beam_PreCommit_Python_Phrase/550/consoleFull

Seems to be unrelated to this PR.

@chamikaramj
Copy link
Contributor

Run Python PreCommit

@tvalentyn
Copy link
Contributor

tvalentyn commented Jun 26, 2019 •
edited
Loading

We investigate Py3 failures as any other failures, in this case it is a flake

16:29:26 ERROR: test_approximate_unique_global_by_sample_size (apache_beam.transforms.stats_test.ApproximateUniqueTest)

@Hannah-Jiang is looking into this flake in https://issues.apache.org/jira/browse/BEAM-7548.

@chamikaramj
Copy link
Contributor

Run Python PreCommit

3 similar comments
@tvalentyn
Copy link
Contributor

Run Python PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jul 9, 2019

Run Python PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jul 9, 2019

Run Python PreCommit

@akedin
Copy link
Contributor

akedin commented Jul 11, 2019

Re-ran the python precommit manually, all seems green: https://scans.gradle.com/s/3s7bzzralmq6w , merging

@akedin akedin merged commit 18f64aa into apache:release-2.14.0 Jul 11, 2019
@pabloem
Copy link
Member Author

pabloem commented Jul 11, 2019

Thank you Anton!

@pabloem pabloem deleted the vp-gcs-dir branch July 11, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pabloem @akedin @chamikaramj @tvalentyn