Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6944] Add MeanByteCountMonitoringInfoToCounterUpdateTransformer #8171

Merged
merged 3 commits into from
Apr 1, 2019

Conversation

Ardagan
Copy link
Contributor

@Ardagan Ardagan commented Mar 29, 2019

BEAM-6944

This is last PR that adds MonitoringInfo transformers to Java DF Worker in near time. I keep some of tech debt in for now to simplify review.
I will do cleanup and refactoring that can be done across all MonitoringInfo transformers in following PRs.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@Ardagan Ardagan changed the title Add MeanByteCountMonitoringInfoToCounterUpdateTransformer [BEAM-6944] Add MeanByteCountMonitoringInfoToCounterUpdateTransformer Mar 29, 2019
@Ardagan
Copy link
Contributor Author

Ardagan commented Mar 29, 2019

Copy link

@ajamato ajamato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR :)

@Ardagan
Copy link
Contributor Author

Ardagan commented Mar 29, 2019

@pabloem (committer)

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file Jiras for TODOs, do not use usernames. This way assignment can move from person to person, and the status of the TODO can be understood, with comments possible.

And especially not usernames that are not even GitHub usernames :-)

@Ardagan
Copy link
Contributor Author

Ardagan commented Mar 29, 2019

@kennknowles
That's a good point regarding usernames. :)
Added jira assigned to myself.

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK that works. Personally, I like full URLs, but that is a non-blocking nit.

@kennknowles kennknowles merged commit e68fafa into apache:master Apr 1, 2019
@Ardagan Ardagan deleted the MBCJava branch April 1, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants