Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply go formatter changes on ./gradlew build #8029

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

Ardagan
Copy link
Contributor

@Ardagan Ardagan commented Mar 11, 2019

These are automatically generated changes when ./gradlew build --continue is executed. I'm not sure whether all of those are caused by gofmt task or some others involved as well.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@Ardagan
Copy link
Contributor Author

Ardagan commented Mar 11, 2019

R: @lostluck (Go sdk contributor)
CC: @pabloem (committer)

@Ardagan
Copy link
Contributor Author

Ardagan commented Mar 11, 2019

R: @youngoli (go sdk contributor)

Copy link
Contributor

@youngoli youngoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are all legit.

I'm surprised these weren't caught before. I would have assumed that Go SDK commits had a format checker like PyLint for Python or Spotless for Java that would've caught these when they were first being committed. Thanks for fixing these Mikhail.

@pabloem
Copy link
Member

pabloem commented Mar 12, 2019

Happy to merge - can you add a JIRA for this?

@Ardagan
Copy link
Contributor Author

Ardagan commented Mar 12, 2019

@youngoli
I believe most people just build project they are working on atm. I find it convenient to sometimes build whole project (I do -X test and some other stuff though).

@pabloem
This is merely applying formatter. I believe that creating jira for such minor changes will only create more clutter. Do you think we should move such discussion to dev-list?

@pabloem pabloem merged commit 58db009 into apache:master Mar 12, 2019
@pabloem
Copy link
Member

pabloem commented Mar 12, 2019

That's fair enough. We also don't want to pollute JIRA too much, and the merge commit leads to the PR, so it's reasonable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants