[BEAM-6431] Implement Execution Time metrics start,process,finish in the Java SDK #7676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajamato
force-pushed
the
execution_metric_implementation
branch
from
e02fd40
to
3c4b47c
Compare
ajamato
force-pushed
the
execution_metric_implementation
branch
from
3c4b47c
to
2aa8a9f
Compare
|
@ryan-williams @Ardagan I also started using matches for testing MonitoringInfos, we can add more matchers over time, this eliminates the need to cleanup/clear timestamps, values, etc when testing monitoring infos. The usage of the states and state tracker mostly happen inside the PCollectionConsumerRegistry and PTransformFunctionRegistry. Once again I have changed its signature and ctors, which affects many tests which are using them (due to the repeated patterns in tests) PTAL and let me know what you think of these changes. |
Ardagan
approved these changes
Feb 5, 2019
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/SimpleExecutionState.java
Outdated
Show resolved
Hide resolved
...ers/core-java/src/test/java/org/apache/beam/runners/core/metrics/MonitoringInfoMatchers.java
Outdated
Show resolved
Hide resolved
...execution/src/test/java/org/apache/beam/runners/fnexecution/control/RemoteExecutionTest.java
Show resolved
Hide resolved
.../java/harness/src/main/java/org/apache/beam/fn/harness/data/PCollectionConsumerRegistry.java
Show resolved
Hide resolved
ajamato
changed the title
swegner
approved these changes
Feb 5, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-6431] Implement Execution Time metrics start,process,finish in the Java SDK
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)