Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency Update] upgrade to shadow plugin 4.0.4 #7622

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

adude3141
Copy link
Contributor

This updates to the latest com.github.jengelman.gradle.plugins:shadow

Enables migration to gradle 5


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@adude3141
Copy link
Contributor Author

R: @swegner

@swegner swegner self-requested a review January 25, 2019 16:59
Copy link
Contributor

@swegner swegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swegner swegner merged commit 00be31e into apache:master Jan 25, 2019
@adude3141 adude3141 deleted the dependency-update-shadow-plugin branch January 25, 2019 17:02
@adude3141
Copy link
Contributor Author

Thx for merging.

@adude3141
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants