Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6500] Add missing javadocs for new public methods #7618

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

swegner
Copy link
Contributor

@swegner swegner commented Jan 24, 2019


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@swegner
Copy link
Contributor Author

swegner commented Jan 24, 2019

R: @youngoli
CC: @ajamato

@swegner
Copy link
Contributor Author

swegner commented Jan 24, 2019

Java pre-commit is passing and this comment-only change doesn't effect Python. I believe this is ready to merge.

@swegner swegner merged commit 98952d2 into apache:master Jan 24, 2019
@swegner swegner deleted the fix-checkstyle branch February 14, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants