-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-6439] Move Python Validates Runner Flink test to PreCommit #7539
Conversation
Run Seed Job |
'^release/.*$', | ||
] | ||
) | ||
builder.build {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new line at end of file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments on #7514
Please set previous name and also adjust references to this job where necessary (git grep
is your friend).
Run Python_VR PreCommit |
Run Python_VR_Flink PreCommit |
1 similar comment
Run Python_VR_Flink PreCommit |
Can't test the job as beam1 is down and all runs are scheduled on beam1. |
1b0206e
to
d79edad
Compare
Run Seed Job |
1 similar comment
Run Seed Job |
d79edad
to
2f44437
Compare
Run Seed Job |
2f44437
to
bbd92ac
Compare
Run Seed Job |
Run Python_PVR PreCommit |
Run Python_PVR_Flink PreCommit |
Need to name job to Python_PVR_Flink as beam_PreCommit_Python_VR_Flink_Cron already existed. We can try deleting beam_PreCommit_Python_VR_Flink_Cron and then try to use Python_VR_Flink. |
1 similar comment
|
bbd92ac
to
17b5a39
Compare
Now I see what you mean. Thanks! |
Hopefully pre-commit check signal will help prevent some of the build breakages we saw lately. But I don't think running all tests of a runners x SDK matrix is feasible going forward. Even just this combination, once it matches the coverage of the Java SDK, is probably no longer suitable for pre-commit. |
@angoenka it does not appear that the job actually runs in pre-commit. https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Commit/ |
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username
) to look at it.Post-Commit Tests Status (on master branch)