Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6439] Move Python Validates Runner Flink test to PreCommit #7539

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

angoenka
Copy link
Contributor

Please add a meaningful description for your change here


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@angoenka
Copy link
Contributor Author

Run Seed Job

'^release/.*$',
]
)
builder.build {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new line at end of file.

Copy link
Contributor

@tweise tweise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on #7514

Please set previous name and also adjust references to this job where necessary (git grep is your friend).

@angoenka
Copy link
Contributor Author

Run Python_VR PreCommit

@angoenka
Copy link
Contributor Author

Run Python_VR_Flink PreCommit

1 similar comment
@angoenka
Copy link
Contributor Author

Run Python_VR_Flink PreCommit

@angoenka
Copy link
Contributor Author

Can't test the job as beam1 is down and all runs are scheduled on beam1.

@angoenka
Copy link
Contributor Author

Run Seed Job

1 similar comment
@angoenka
Copy link
Contributor Author

Run Seed Job

@angoenka
Copy link
Contributor Author

Run Seed Job

@angoenka
Copy link
Contributor Author

Run Seed Job

@angoenka
Copy link
Contributor Author

Run Python_PVR PreCommit

@angoenka
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@angoenka
Copy link
Contributor Author

Need to name job to Python_PVR_Flink as beam_PreCommit_Python_VR_Flink_Cron already existed. We can try deleting beam_PreCommit_Python_VR_Flink_Cron and then try to use Python_VR_Flink.
Successful run: https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Phrase/1/

@angoenka
Copy link
Contributor Author

cc: @tweise @robertwb

@angoenka
Copy link
Contributor Author

Ping: @tweise @robertwb

1 similar comment
@angoenka
Copy link
Contributor Author

Ping: @tweise @robertwb

@tweise
Copy link
Contributor

tweise commented Jan 22, 2019

git grep 'beam_PostCommit_Python_VR_Flink' - see earlier comment

@angoenka
Copy link
Contributor Author

Now I see what you mean. Thanks!
Updated the PR comments and readme to remove reference for the old postcommit job.
But I would say that having these run available in post commit and visible in PR gave a lot of confidence in the system.

@tweise
Copy link
Contributor

tweise commented Jan 23, 2019

Hopefully pre-commit check signal will help prevent some of the build breakages we saw lately. But I don't think running all tests of a runners x SDK matrix is feasible going forward. Even just this combination, once it matches the coverage of the Java SDK, is probably no longer suitable for pre-commit.

@tweise tweise merged commit acb782d into apache:master Jan 23, 2019
@tweise
Copy link
Contributor

tweise commented Jan 23, 2019

@angoenka it does not appear that the job actually runs in pre-commit.

https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Commit/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants