Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6009] Modify Github template to include Flink PVR for batch/str… #7370

Merged
merged 3 commits into from
Jan 6, 2019

Conversation

mxm
Copy link
Contributor

@mxm mxm commented Dec 28, 2018

The old build task has been split into a batch and a streaming job.

This is how it looks: https://github.com/mxm/beam/blob/bd8de6de159bc92daaea4d0cccbd7dfae80f0b86/.github/PULL_REQUEST_TEMPLATE.md

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

…eaming

The old build task has been split into a batch and a streaming job.
@mxm mxm requested a review from swegner December 28, 2018 12:08
@mxm
Copy link
Contributor Author

mxm commented Dec 28, 2018

As a follow-up, I think we could rotate the matrix and have the SDKs as columns?

@mxm mxm requested a review from tweise December 30, 2018 19:50
@tweise
Copy link
Contributor

tweise commented Dec 30, 2018

The changes also need to be made in README.md. I notice that the formatting looks a bit messed up on the pull request page (before and after this PR) and that the Flink entries are not stacked vertically.

@mxm
Copy link
Contributor Author

mxm commented Dec 30, 2018

They are stacked vertically for me, but it depends on the browser and screen size. I think we can address the design separately. I'd like to fix the broken link to the Flink PVR tests before.

The README only includes the PreCommit tests. So nothing is broken there. Good idea though to include all links.

@tweise
Copy link
Contributor

tweise commented Dec 30, 2018

This should list the exact same (post commit) builds: https://github.com/apache/beam/blob/master/README.md

@mxm
Copy link
Contributor Author

mxm commented Jan 4, 2019

@tweise I updated the matrix in the README. Should be good to go now.

@tweise tweise merged commit abe3220 into apache:master Jan 6, 2019
@angoenka angoenka mentioned this pull request Jan 7, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants