[BEAM-5701] port datastore_write Python integration tests to Beam #6642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanzou
force-pushed
the
BEAM-5701/port_python_datastore_write_it
branch
4 times, most recently
from
cca6352
to
d819636
Compare
|
Run Python PostCommit |
yifanzou
force-pushed
the
BEAM-5701/port_python_datastore_write_it
branch
3 times, most recently
from
1c940fd
to
898433e
Compare
|
+R @jasonkuster |
yifanzou
force-pushed
the
BEAM-5701/port_python_datastore_write_it
branch
from
898433e
to
78f6076
Compare
|
Run Python PostCommit |
jasonkuster
reviewed
Oct 11, 2018
| **extra_opts)) | ||
|
|
||
| @attr('IT') | ||
| def test_datastore_write_limit(self): |
There was a problem hiding this comment.
Can we have two of these, a limit and non-limit test? Seems strange to allow parameterizing it and then not do so.
jasonkuster
approved these changes
Oct 11, 2018
yifanzou
force-pushed
the
BEAM-5701/port_python_datastore_write_it
branch
from
78f6076
to
5b023b6
Compare
|
Renamed it to 'datastore_write_it_pipeline' |
|
Wait, do not merge. The test failed on my local. Looking into that. |
|
Run Python PostCommit |
|
@jasonkuster No worry, mis-configurations in my local environment. The datastore_write_it_test passed in the postcommit. The error is no relevant to this test. |
|
Run Python PostCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)