[BEAM-4559] Fix typo in _ghprb suffix #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmyrvold
reviewed
Jun 20, 2018
| @@ -42,7 +42,7 @@ class JobBuilder { | |||
| jobDefinition = {}) { | |||
| JobBuilder jb = new JobBuilder(scope, jobDefinition) | |||
| jb.defineAutoPostCommitJob(nameBase) | |||
| jb.defineGhprbTriggeredJob(nameBase + "_hgprb", triggerPhrase, githubUiHint, false) | |||
| jb.defineGhprbTriggeredJob(nameBase + "_PullRequest", triggerPhrase, githubUiHint, false) | |||
There was a problem hiding this comment.
There have been issues where long job names cause test failures, how about _PR as the suffix?
alanmyrvold
approved these changes
Jun 20, 2018
charlesccychen
pushed a commit
to charlesccychen/beam
that referenced
this pull request
Jul 24, 2018
[BEAM-4559] Fix typo in _ghprb suffix
charlesccychen
pushed a commit
to charlesccychen/beam
that referenced
this pull request
Jul 26, 2018
[BEAM-4559] Fix typo in _ghprb suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts are working correctly, but change in suffix is required.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.