Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preinstalled virtualenv on Jenkins nodes. #5324

Merged
merged 1 commit into from
May 14, 2018

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented May 9, 2018

[INFRA-16508]

DESCRIPTION HERE


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@tvalentyn
Copy link
Contributor Author

R: @jasonkuster
cc: @udim
cc: @alanmyrvold

@tvalentyn
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@jasonkuster
Copy link
Contributor

Changes LGTM. Is failure a KI?

@udim
Copy link
Member

udim commented May 10, 2018

Another solution is to do the same as in #5146 (by @pabloem)

@pabloem
Copy link
Member

pabloem commented May 10, 2018 via email

@tvalentyn
Copy link
Contributor Author

Failure is a different issue, that's also needs fixing. I think we can merge this and work in parallel on migrating the suite to Gradle.

Copy link
Contributor

@jasonkuster jasonkuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@jasonkuster jasonkuster merged commit 1c8f6a2 into apache:master May 14, 2018
@tvalentyn tvalentyn deleted the patch-11 branch August 27, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants