Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3800] Set uids on Flink operators #4903

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Conversation

grzegorz8
Copy link

@grzegorz8 grzegorz8 commented Mar 20, 2018

In most of the cases the transform's name is used as UID, since the transform's name is unique across the job. The uid is not set for PartitionTransformations (dataStream.keyBy(_)) and simple stateless flatMaps wrapping one object with another one.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

In most of the cases the transform's name is used as UID, since
the transform's name is unique across the job.

The uid is not set for PartitionTransformations (dataStream.keyBy(_))
and simple stateless flatMaps wrapping one object with another one.
@aljoscha
Copy link
Contributor

retest this please

@aljoscha aljoscha merged commit ab3c38d into apache:master Mar 26, 2018
@aljoscha
Copy link
Contributor

Thanks for working on this! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants