Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-2393] Make BoundedSource fault-tolerant in FlinkRunner Streaming mode #4895

Closed
wants to merge 3 commits into from
Closed

[BEAM-2393] Make BoundedSource fault-tolerant in FlinkRunner Streaming mode #4895

wants to merge 3 commits into from

Conversation

grzegorz8
Copy link

@grzegorz8 grzegorz8 commented Mar 19, 2018 •
edited
Loading

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@grzegorz8 grzegorz8 changed the title Beam 2393 [BEAM-2393] BoundedSource is not fault-tolerant in FlinkRunner Streaming mode Mar 20, 2018
@grzegorz8
Copy link
Author

retest this please

@grzegorz8 grzegorz8 changed the title [BEAM-2393] BoundedSource is not fault-tolerant in FlinkRunner Streaming mode [BEAM-2393] Make BoundedSource fault-tolerant in FlinkRunner Streaming mode Mar 20, 2018
@aljoscha
Copy link
Contributor

Could you please rebase and see if the tests pass locally?

Grzegorz Kołakowski added 3 commits March 26, 2018 07:43
[BEAK-2393] Make reader state update and element emission atomic
4477d99 
Reader advancement should be considered as reader state update too.
Therefore, the reader's advancement and element emission are in the
same synchronized section.
[BEAM-2393] Make BoundedSource fault-tolerant
dd6be39
[BEAM-2393] Wrap UnboundedSourceWrapper to remove ValueWithRecordId f…
f07e5f5 
…rom output type
@grzegorz8
Copy link
Author

grzegorz8 commented Mar 26, 2018 •
edited
Loading

Rebase done.
Generally the tests pass. However, I've run mvn clean install -pl sdks/python -am -amd locally with the following error:

___________________________________ summary ____________________________________
py27: commands succeeded
ERROR: py27-gcp: commands failed
py27-cython2: commands succeeded
py27-lint: commands succeeded
py3-lint: commands succeeded
docs: commands succeeded
[ERROR] Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166)

There is no meaningful error message.
Edit: Ok, I see. It fails due to lack of credentials:

DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or
explicitly create credential and re-run the application. For more
information, please see
https://developers.google.com/accounts/docs/application-default-credentials.
So that's ok.

asfgit pushed a commit that referenced this pull request Mar 27, 2018
@aljoscha
Merge pull request #4895: [BEAM-2393] Make BoundedSource fault-tolera…
f93a332 
…nt in FlinkRunner Streaming mode
@aljoscha
Copy link
Contributor

Thanks a lot, @grzegorz8! 😄 I merged this.

@aljoscha aljoscha closed this Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grzegorz8 @aljoscha