InstantCoder: stop boxing Longs unnecessarily #3270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecwik
reviewed
May 31, 2017
| } | ||
|
|
||
| /** A primitive version of {@link #encode(Long, OutputStream)}. */ | ||
| public void encodeLong(long value, OutputStream outStream) throws IOException, CoderException { |
There was a problem hiding this comment.
Instead of making this and decodeLong public, why not just copy this code into InstantCoder and stop coupling the two coders together?
In encode, and similar in decode, the existing path goes Instant->long (inside of converter) long->Long (returned from converter) Long->long (inside of LongCoder). This is a relatively small improvement, but as we encode timestamps for every single element, this is likely to make a difference in lightweight stages of pipelines.
|
PTAL |
|
Build finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In encode, and similar in decode, the existing path goes
Instant->long (inside of converter)
long->Long (returned from converter)
Long->long (inside of LongCoder).
This is a relatively small improvement, but as we encode timestamps
for every single element, this is likely to make a difference in
lightweight stages of pipelines.
R: @lukecwik @bjchambers